Implement custom ArrayList#1745
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the core functionality of your custom ArrayList! The logic for adding, removing, and resizing the array is well-structured and correct.
However, one change is needed before this can be approved. Your code includes an import java.util.Objects; statement in src/main/java/core/basesyntax/ArrayList.java. This violates a key project constraint which prohibits the use of utility classes like Objects or Arrays [CHECKLIST ITEM #2].
Please remove this unused import to fully comply with the task requirements. After that small fix, your solution will be good to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| package core.basesyntax; | ||
|
|
||
| import java.util.NoSuchElementException; | ||
| import java.util.Objects; |
There was a problem hiding this comment.
This import violates checklist item #2: "Don't use Objects, Arrays, or any other util class." Please remove any unused imports and ensure no utility classes from java.util are used in your implementation.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution as you have successfully addressed the previous feedback by removing the disallowed import. Your ArrayList implementation is now fully compliant with all project requirements and constraints. The code is clean, correct, and demonstrates good practices like using private helper methods for index validation and array resizing. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.