Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

Conversation

@Bud-Macaulay
Copy link
Contributor

WIP PR;
Wordy desc. below - not expecting you to read it, we can chat potentially.

Just rewrote the phonon and bands index files to incorporate the bands visualiser ive been working on. Mostly a new component that wraps the plotly plot into a div (with some formatting)

In principle it should be fairly easy to add this re-arrange bands button/download jsons but decided to keep the component clean for now. I dont know if CBM and VBM are passed through aiida/easy to calculate but the component should be able to accept singular traces (lines/markers) as input so if its easy to calculate we could maybe throw that in too? (this raises a question on legend etc, the legend is always going to be quite big or quite unreadable).

Could be an idea to show VBM and CBM where applicable as text+marker inside the textbox to the right.

There is a moderate disconnect now with the plotly plotter in the interactive section (albeit less than before), I think the one there looks great and we can maybe restyle the ones in the main body to match it, or make a small change on that components end?

@Bud-Macaulay Bud-Macaulay requested a review from eimrek May 25, 2025 09:54
@Bud-Macaulay
Copy link
Contributor Author

Also quick comment: - I presume there is spin active systems on MC2D, i have not done any bandsplitting yet so they are rendered as the same traceFormat. I'm not sure if its a desired to do so, this could be done inside the react component but i think it might be a bit more consistent to split the bands before calling the component (we currently normalise to fermi, using some convoluted math Kristian wrote, before passing to the component too)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant