Skip to content

docs(school): swagger 문서 수정, default 0 -> 1#282

Merged
huhdy32 merged 3 commits intodevelopfrom
fix/school
Jan 22, 2026
Merged

docs(school): swagger 문서 수정, default 0 -> 1#282
huhdy32 merged 3 commits intodevelopfrom
fix/school

Conversation

@huhdy32
Copy link
Collaborator

@huhdy32 huhdy32 commented Jan 22, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated pagination parameter validation. Page numbering now starts from 1 instead of 0, and minimum page size increased to 1 to ensure valid query results.

✏️ Tip: You can customize this high-level summary in your review settings.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @huhdy32, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the pagination parameters within the SchoolQueryController to align with 1-based indexing conventions. By changing the default pageIndex and the minimum allowed values for both pageIndex and pageSize from 0 to 1, the API now enforces more consistent and intuitive pagination behavior, preventing potential issues with invalid input ranges.

Highlights

  • Pagination Parameter Defaults: The pageIndex parameter's default value in SchoolQueryController.java has been updated from 0 to 1.
  • Pagination Parameter Range Validation: The minimum allowed value for both pageIndex and pageSize parameters in SchoolQueryController.java has been adjusted from 0 to 1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Parameter constraint adjustments for the loadInfos method in SchoolQueryController: the pageIndex default value shifted from 0 to 1 with matching range constraint update (min 0→1), and pageSize minimum constraint increased from 0 to 1.

Changes

Cohort / File(s) Summary
Parameter Validation Updates
app/api/mathrank-school-read-api/src/main/java/kr/co/mathrank/app/api/school/SchoolQueryController.java
Updated loadInfos method parameter constraints: pageIndex default changed from "0" to "1" with Range updated to min=1; pageSize Range constraint updated from min=0 to min=1

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 The pages now start counting from one,
Not zero—a shift, simply done.
With bounds tightened snug,
No empty page jug,
Hop on, validation's begun! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The PR title describes a swagger documentation fix and default value change (0 → 1), but the actual changes are code modifications to validation constraints in SchoolQueryController, not just documentation. Update the title to reflect the actual code changes, such as 'fix(school): adjust pagination parameter validation constraints' or 'fix(school): change default pageIndex from 0 to 1 and enforce minimum values'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@huhdy32 huhdy32 enabled auto-merge (squash) January 22, 2026 04:56
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 페이지네이션 파라미터인 pageIndexpageSize를 1 기반으로 변경하여 API의 사용성과 일관성을 개선했습니다. pageIndex의 기본값이 1로 설정되었고, pageIndexpageSize의 최솟값 또한 1로 변경되었습니다. 좋은 변경이라고 생각합니다. 코드 일관성을 높이기 위한 작은 제안이 한 가지 있습니다.

@huhdy32 huhdy32 changed the title docs(school): swagger에 default로 1인 문제 수정 docs(school): swagger 문서 수정, default 0 -> 1 Jan 22, 2026
@huhdy32 huhdy32 merged commit 561a94c into develop Jan 22, 2026
2 checks passed
@huhdy32 huhdy32 deleted the fix/school branch January 22, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant