Fix module capitalisation and pagination bug#1
Open
karutsuki wants to merge 2 commits intomatthijsbrouwer:masterfrom
Open
Fix module capitalisation and pagination bug#1karutsuki wants to merge 2 commits intomatthijsbrouwer:masterfrom
karutsuki wants to merge 2 commits intomatthijsbrouwer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues:
api.pyline 1337 was callingself.experiment(id,page)(mind the page argument), butself.experimentonly accepts a single argument (id). The methodself._experimentis the one that admits the argumentsidandpage, so I change the code to use that one.I have tested these changes locally and verified that they solve the issues.