Modernize tooling and project configuration #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update fastlane snapshot config with new devices - Remove SimulatorStatusMagic, which doesn't work as easily on newer simulators - Configure fastlane snapshot to make the status bar pretty - Annotate screenshot test case with `@MainActor` as required by the snapshot helper function A few issues I ran into: - The iOS simulator inherits the 12/24-hour time format preference from the macOS host *at the time the simulator is created* and does not expose a way to change this setting via either the Settings app or an `xcrun simctl` command. The fix was to manually run `plutil -remove AppleICUForce24HourTime ~/Library/Developer/CoreSimulator/Devices/[Simulator UUID]/data/Library/Preferences/.GlobalPreferences.plist` for each simulator before running fastlane snapshot. - There are imperceptible differences between screenshots rendered when my MBP is running on battery power vs running off a power adapter. I opted to capture screenshots when connected to power. - The (in)visibility of the home indicator at the bottom of each screenshot is flaky. Most screenshots don't include it, but I had to re-generate several of them to get them all without home indicators.
When tests fail, the more specific matchers provide better error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.