Conversation
Documentation for Event Listeners component mautic#215
RCheesley
left a comment
There was a problem hiding this comment.
Thanks so much for the great work on this PR @ifeoluwafavour - it's fantastic to see these docs coming over to the new documentation!
I've left a bunch of suggestions to fix the many Vale suggestions from Reviewdog, have a look and see what you think!
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
referenced Symfony's docs event subscribers link file
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
|
Hello @RCheesley I have applied the suggested changes. To accurately follow the external link syntax, I created a pull request to include Symfony's docs event subscribers link file to the link folder: |
RCheesley
left a comment
There was a problem hiding this comment.
Some tweaks to fix the heading nestings, and I've asked the devs to do a technical review, too! Thanks for the great work so far!
correct heading syntax Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
changed to unique heading name instead of 'subscribers'
|
Thank you @RCheesley for your guidance so far! I changed 'Subscribers' to 'Event Sunscribers' in the recent commit. Is it a better heading name? |
RCheesley
left a comment
There was a problem hiding this comment.
Looks like just a vale fix and we're good to go! 🚀 Thanks @ifeoluwafavour for all the hard work here!
|
I think this is GTG but we'll need to forward-port it to other branches. |
We only have |
Documentation for Event Listeners component #215