Draft
Conversation
dennisameling
commented
Dec 4, 2022
docs/components/config.rst
Outdated
| This prevents Symfony from throwing errors if the parameter gets used during cache compilation or if accessed directly from the container without checking if it exists first. | ||
| Defining the parameters in the Plugin's config file ensures that it always exists. | ||
|
|
||
| To add config options to the Configuration section, you will need to add an :ref:`Event Listener<Event listeners>`, a config :ref:`form type<Forms>`, and a specific view (TODO). |
Member
Author
There was a problem hiding this comment.
This needs #86 to be merged first, so we can link to the Form Type section from here.
Member
There was a problem hiding this comment.
That PR is merged now so should be good to go with this comment :)
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
dennisameling
commented
Dec 6, 2022
| This prevents Symfony from throwing errors if the parameter gets used during cache compilation or if accessed directly from the container without checking if it exists first. | ||
| Defining the parameters in the Plugin's config file ensures that it always exists. | ||
|
|
||
| To add config options to the Configuration section, you need to add an :ref:`Event Listener<Event listeners>`, a config :ref:`form type<Forms>`, and a specific view (TODO). |
Member
Author
There was a problem hiding this comment.
Looks like we don't have the docs on MVC in the new docs yet: https://developer.mautic.org/#mvc
Have just created a separate issue for that: #99
Member
There was a problem hiding this comment.
OK great - so we are just pending the MVC section for now with this part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Needs #86