Conversation
RCheesley
left a comment
RCheesley
left a comment
There was a problem hiding this comment.
A vale fix and a small comment about extra line break (not sure if it's intentional)
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
|
Comment resolved @RCheesley |
|
Please rebase this to 5.x then we can review it accordingly. Main isn't used any more (might need to change the default branch on your fork?) |
will resolve it today |
|
@fakela we can't merge this until you rebase please! :) |
|
@fakela @favour-chibueze do you think this could be rebased please? Or cherry-picked and created on a new branch? It'll need to go into the 5.2, 6.0 and 7.x branches as this was merged in 5.1.0. |
|
Would be great to get this one rebased @fakela or cherry picked onto a new branch. |
|
@adiati98 if you have time, do you think you could cherry pick this one? The feature has been in Mautic since 5.1 so it'll need to go to 5.2, 6 and 7. |
|
Closing this as this PR has been cherry-picked in #563. |
4 participants
mautic/mautic#12219