Open
Conversation
Previously the code listened for `close`. This was changed to `end` in the previous commit since an input buffer may not have an fd to close. We do not need to test for cancelation in the new `end` handler because as per the yazul docs "After [the `error` event] has been emitted, no further `entry`, `end`, or `error` events will be emitted."
Author
|
Not sure why codecov didn't comment on this PR, but FWIW: $ yarn coverage
yarn run v1.22.10
$ nyc --reporter=lcov --reporter=text ava
14 tests passed
----------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
----------|---------|----------|---------|---------|-------------------
Done in 1.51s.Basically there aren't very many different logic branches. Other than opening the yauzl.ZipFile and checking for the 'done' signal, the rest of the codepaths are the same as before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
extractBuffer()function so that extract-zip can be used on zipfile content that is in a read buffer instead of stored in a file.To preserve extract-zip's existing export signature, extractBuffer is a new property on the existing exported function.
Closes #108