Skip to content

fix: ecr tagging #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxday merged 7 commits into from
Jan 2, 2026
Merged

fix: ecr tagging #3446

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbdbf1b
Update push-to-ecr.yml
maxday Jan 2, 2026
115697b
fix: ecr
maxday Jan 2, 2026
08d76e1
fix: ecr
maxday Jan 2, 2026
e399770
fix: ecr
maxday Jan 2, 2026
46c5a96
fix: ecr
maxday Jan 2, 2026
e8643f7
fix: ecr
maxday Jan 2, 2026
9764389
fix: remove ecr untagged
maxday Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions container-uploader/app.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,18 @@ const buildDockerImage = async (
childProcess.execSync(
`unzip ${runtime.path}_${architecture}.zip -d ${runtime.path}`
);
const platform = architecture === "x86_64" ? "linux/amd64" : "linux/arm64";
const tag = `${accountId}.dkr.ecr.${region}.amazonaws.com/lambda-perf:${runtime.path}-${architecture}`;
const cmdLine = `docker build . -f Dockerfile.sample -t ${tag} --build-arg baseImage='${runtime.image.baseImage}' --build-arg handlerCode='${runtime.path}' --build-arg handlerCmd='${runtime.handler}'`;
const cmdLine = `
DOCKER_BUILDKIT=0 docker build . \
-f Dockerfile.sample \
--platform ${platform} \
-t ${tag} \
--build-arg baseImage='${runtime.image.baseImage}' \
--build-arg handlerCode='${runtime.path}' \
--build-arg handlerCmd='${runtime.handler}'
`;
console.log(cmdLine);
childProcess.execSync(cmdLine);
const cmdLogin = `aws ecr get-login-password --region ${region} | docker login --username AWS --password-stdin ${accountId}.dkr.ecr.${region}.amazonaws.com`;
console.log("docker logging in!");
Expand Down Expand Up @@ -119,7 +129,7 @@ const runtimeFromRuntimeId = (manifest, runtimeId) => {
const runtime = manifest.find(r => {
return r.path === runtimeId;
});
if(!runtime) {
if (!runtime) {
throw "cound not find the runtime"
}
console.log(runtime);
Expand Down
Loading