Improve robustness by checking for search & replace keys.#9
Open
lukesrw wants to merge 1 commit intomaxeonyx:mainfrom
Open
Improve robustness by checking for search & replace keys.#9lukesrw wants to merge 1 commit intomaxeonyx:mainfrom
search & replace keys.#9lukesrw wants to merge 1 commit intomaxeonyx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you omit the
searchkey fromReplacementConfigthis isn't caught and leads to the undesired behaviour of replacing every character in the file with thereplacekey.In addition if you omit the
replacekey fromReplacementConfigthis instead results in replacing anysearchmatches with the string"undefined"instead of either doing nothing or replacing with an empty string (which, for the sake of this patch, I've assumed would likely be the desired behaviour?).This patch does the following:
ReplacementConfiginterface to setsearchandreplacekeys to potentially be undefinedapplicableReplacementsloop to warn and skip replacements with undefinedsearchkeysreplaceis undefined