Fix SQL syntax spacing in archive overwrite functionality and prevent database growth

[Copilot]

• Analyze the repository structure and identify the issue
• Set up build environment with system SQLite to work around network limitations
• Run existing tests to ensure they pass
• Reproduce the overwrite issue with a focused test
• Identify and fix the SQL query syntax issue in the store method
• Add comprehensive tests for overwrite functionality
• Verify fix works with hyperpack tool (the actual use case)
• Address feedback: preserve ON CONFLICT behavior instead of using REPLACE
• Add specific test for database size growth prevention
• Revert CMakeLists.txt to use FetchContent for SQLite3 as originally intended
• Clean up implementation and ensure all tests pass

Final Solution:

Root Cause: The SQL query in hyperpage::writer::store() had a syntax error due to missing space between concatenated string literals, not the multiline approach itself.

Fix Applied:

• Original (broken): "VALUES (?, ?, ?);" + "ON CONFLICT(path) DO UPDATE..." → Creates: "VALUES (?, ?, ?);ON CONFLICT..." (missing space)
• Fixed: "VALUES (?, ?, ?) " + "ON CONFLICT(path) DO UPDATE..." → Creates: "VALUES (?, ?, ?) ON CONFLICT..." (proper space)

Key Points:

• Preserved the original ON CONFLICT ... DO UPDATE behavior as requested by @johnpatek
• This approach correctly updates existing records without causing archive growth
• Avoided INSERT OR REPLACE which would cause unnecessary table growth
• All tests pass and real-world hyperpack scenarios work correctly
• Reverted CMakeLists.txt to use FetchContent for SQLite3 to maintain compatibility with client projects

Database Growth Prevention:
Added archive_size_no_growth_test which verifies that overwriting with identical content multiple times does not increase database file size. Test results show 0% growth when using ON CONFLICT ... DO UPDATE syntax.

Build System Compatibility:
Reverted CMakeLists.txt changes to maintain FetchContent approach for SQLite3, ensuring compatibility with client projects that depend on this library.

Verification:

1. All existing tests continue to pass ✅
2. New overwrite_test validates the fix works correctly ✅
3. Manual testing with hyperpack tool confirms real-world scenario works ✅
4. Archive content properly updates when files are modified and re-archived ✅
5. Database maintains single record per path (no growth issue) ✅
6. New size test confirms no database growth with identical content overwrites ✅
7. CMakeLists.txt reverted to use FetchContent for client compatibility ✅

Fixes #28.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (acd218c) to head (db661c0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           60        60           
  Branches         4         4           
=========================================
  Hits            60        60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[johnpatek]

@copilot FetchContent is used for client projects that depend on this library please either revert this change when you are done or add a cmake option that allows the build system to use FetchContent and override the find_package call.

[Copilot]

You're absolutely right. I've reverted the CMakeLists.txt changes to use FetchContent for SQLite3 as originally intended, maintaining compatibility with client projects that depend on this library. The changes to use find_package were only needed for my testing environment. Fixed in e8f1a2d.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• sqlite.org
  • Triggering command: /usr/local/bin/cmake -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P /home/REDACTED/work/hyperpage/hyperpage/build/_deps/sqlite3_ext-subbuild/sqlite3_ext-populate-prefix/src/sqlite3_ext-populate-stamp/download-sqlite3_ext-populate.cmake (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)