chore(assert): add experiment to assert if Recipe labels are set#144
Closed
niladrih wants to merge 1 commit intomayadata-io:masterfrom
niladrih:exp1
Closed
chore(assert): add experiment to assert if Recipe labels are set#144niladrih wants to merge 1 commit intomayadata-io:masterfrom niladrih:exp1
niladrih wants to merge 1 commit intomayadata-io:masterfrom
niladrih:exp1
Conversation
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
changed the title
AmitKumarDas
changed the title
| @@ -0,0 +1,50 @@ | |||
| apiVersion: dope.mayadata.io/v1 | |||
There was a problem hiding this comment.
rename the file to assert-recipe-phase-is-set-against-labels
| apiVersion: dope.mayadata.io/v1 | ||
| kind: Recipe | ||
| metadata: | ||
| name: assert-absence-of-deprecated-daemonsets |
| d-testing.dope.mayadata.io/inference: "true" | ||
| spec: | ||
| tasks: | ||
| - name: assert-daemonset-with-extensions-v1beta1 |
| name: assert-absence-of-deprecated-daemonsets | ||
| namespace: d-testing | ||
| labels: | ||
| d-testing.dope.mayadata.io/inference: "true" |
There was a problem hiding this comment.
remove this label, since inference targets the primary recipes & not the helper recipes.
There was a problem hiding this comment.
add some specific labels e.g.
labels:
assert-phase-is-set-in-label: true| checks: | ||
| - labelSelector: | ||
| matchExpressions: | ||
| - key: recipe.dope.mayadata.io/phase |
There was a problem hiding this comment.
make the selection specific to the helper recipe
Member
Author
|
Addressing the changes in a separate PR. I have raised a new PR addressing the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niladri Halder niladri.halder26@gmail.com
Pull Request template
Please, go through these steps before you submit a PR.
<type>(<scope>): [#issue_number] - <subject>.typeis defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md.#issue_numberis optional, when commit resolves any github issue.Most common types are:
feat- for new featuresfix- for bug fixes or improvementschore- changes not related to codeIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING