Dont expire sessions using TTL based on time passed since creation#47
Open
papadp wants to merge 2 commits intombr:masterfrom
Open
Dont expire sessions using TTL based on time passed since creation#47papadp wants to merge 2 commits intombr:masterfrom
papadp wants to merge 2 commits intombr:masterfrom
Conversation
Fix a bug where sessions supporting TTL were invalidated based on time passed since session creation and not since the last update of the session
Revert to the formatting used in master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following case:
An application sets
flask.session.modifed = Trueand is using a TTL supporting store.The result is that sessions are expired based on absolute time passed since the creation of the session without any consideration of whether a session has been updated (and it's TTL also updated).