feat(UpcomingDepartures): use vehicle status #2926
Conversation
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
I like the approach! It's a bit different from how I was originally thinking this would be done, but I actually like your overall approach better!
My comment about showing Approaching for too long / still using the time even when we have vehicle info, is blocking.
|
|
||
| defp realtime_arrival_status(%{route_type: :subway, vehicle_status: vehicle_status}) | ||
| when vehicle_status != nil do | ||
| arrival_status_from_vehicle(vehicle_status) |
There was a problem hiding this comment.
Issue (blocking): This is a bit too coarse. We still need to use arrival_time here, or else we'll show Approaching/Arriving for trains that have to make a long journey (e.g. it's six minutes from JFK to North Quincy, but we don't want to show Approaching for that whole time).
|
@joshlarson I refactored this enough that I feel like it may as well be a new PR 😵 |
2 participants
Scope
Asana Ticket: [SF/UD] Subway: 🐞 Use vehicle info to inform "Approaching"/"Arriving"/"Boarding"
Implementation
For each prediction, fetch the related vehicle. If that vehicle has a populated
statusand the vehicle's corresponding stop is the same as the stop we're viewing in SF2.0, then we use this to display "Approaching"/"Arriving"/"Boarding".How to test
Note this change only affects subway lines.
I like to watch Upcoming Departures alongside the corresponding screens in Screenplay. Screenplay doesn't update the previews as frequently as our LiveView updates, but you can see matching statuses!