refactor(TripDetails): use UpcomingDepartures vehicle if same trip #2932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] Trip Details: Hide predictions for stops that the vehicle has already visited
Implementation
A refactor I did to make this easier -- The vehicle used in
UpcomingDeparturesis already matched to the predicted schedule's stop and stop sequence -- if it also is on the predicted schedule's trip (as opposed to a prior trip or some such), we can pass it intoTripDetailsdirectly and do the rest.The actual task -- in the last commit, I adjust the logic to remove any prior trip stops based on the vehicle location (basically option B in the Asana ticket).
Screenshots
How to test
Since this was an intermittently-seen problem I'm not sure how to reliably reproduce, but I remember seeing it on the 9 bus semi-often...