Fix for rare crash of ILL_IN4 / MPI #2287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Fix for rare crash of ILL_IN4 / MPI. As can be seen in e.g. https://new-nightly.mcstas.org/2026-01-06_output.html (no access to underlying sim data, sorry) ILL_IN4 crashes at times.
The underlying reason seems in principle simple:
Master is meant to write the file
Dirac2D.sqw, but naturally other nodes may ‘overtake’ and attempt to load a non-existent or non-completed file…The addition of an MPI_Barrier at the end if init seems to help - we should consider if this should be added at code-generation level instead….
My contribution contains something else