Skip to content

fix writeCsv for OptionalColumn #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcoady wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −10
Open

fix writeCsv for OptionalColumn #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c64817
fix `writeCsv` for `OptionalColumn` writing `Maybe a` values instead…
mcoady Jan 21, 2026
d0f6b5a
replace use of `Text.show` and handle `OptionalColumn` of `Maybe Text…
mcoady Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/DataFrame/IO/CSV.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,11 +428,9 @@ getRowAsText df i = V.ifoldr go [] (columns df)
++ "the other columns at index "
++ show i
go k (OptionalColumn (c :: V.Vector (Maybe a))) acc = case c V.!? i of
Just e -> textRep : acc
where
textRep = case testEquality (typeRep @a) (typeRep @T.Text) of
Just Refl -> fromMaybe "Nothing" e
Nothing -> (T.pack . show) e
Just e -> case testEquality (typeRep @a) (typeRep @T.Text) of
Just Refl -> fromMaybe T.empty e : acc
Nothing -> maybe T.empty (T.pack . show) e : acc
Nothing ->
error $
"Column "
Expand Down
8 changes: 3 additions & 5 deletions src/DataFrame/Lazy/IO/CSV.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,9 @@ getRowAsText df i = V.ifoldr go [] (columns df)
++ "the other columns at index "
++ show i
go k (OptionalColumn (c :: V.Vector (Maybe a))) acc = case c V.!? i of
Just e -> textRep : acc
where
textRep = case testEquality (typeRep @a) (typeRep @T.Text) of
Just Refl -> fromMaybe "Nothing" e
Nothing -> (T.pack . show) e
Just e -> case testEquality (typeRep @a) (typeRep @T.Text) of
Just Refl -> fromMaybe T.empty e : acc
Nothing -> maybe T.empty (T.pack . show) e : acc
Nothing ->
error $
"Column "
Expand Down