Fixes an issue with the long-form Command Header where the Parameter …#619
Open
mr-intj wants to merge 1 commit intomdaus:mainfrom
Open
Fixes an issue with the long-form Command Header where the Parameter …#619mr-intj wants to merge 1 commit intomdaus:mainfrom
mr-intj wants to merge 1 commit intomdaus:mainfrom
Conversation
…List Length (2nd word) incorrectly included the padding octet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…List Length (2nd word) incorrectly included the padding octet.
Problem was originally detected by CIVA (NITF validation utility), which rejected an otherwise valid NITF with an embedded Nitro-generated CGM.
I took a valid CGM, round-tripped it through Nitro, and compared against the original in a hex editor. In long-form command headers, the parameter list length was including the padding octet after the parameter list in its count of bytes, which is incorrect according to the CGM binary spec (also, the short-form command header doesn't include the padding octet either).