Urgent fixes for Python 3 #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Closes mdsecactivebreach#31 * Closes mdsecactivebreach#32 * Closes mdsecactivebreach#33 * Closes mdsecactivebreach#35 * Closes mdsecactivebreach#36 * Closes mdsecactivebreach#38 * Closes mdsecactivebreach#40
* Closes mdsecactivebreach#29 * Closes mdsecactivebreach#34 * Closes mdsecactivebreach#37
* UTF-8 codecs are used for reading files, encoding and decoding operations. The correct codecs to use should be Latin-1. Reason being that UTF-8 does not include 0xFE and 0xFF. . This poses a significant issue that goes unnoticed during testing, but affects core functionality. Since raw shellcode, which is essentially read from a file, may contain those characters, subsequent encoding/decoding is going to be incorrect, thus affecting the final payload which breaks at runtime. . For more information, please refer to the following links: https://en.wikipedia.org/wiki/UTF-8 https://en.wikipedia.org/wiki/ISO/IEC_8859-1 https://docs.python.org/3/howto/unicode.html#id2 https://datatracker.ietf.org/doc/html/rfc3629#section-3 * Closes mdsecactivebreach#29 * Closes mdsecactivebreach#34 * Closes mdsecactivebreach#37 * Fixes mdsecactivebreach#42
This commit addresses Python 3.12 Syntax Warnings. This is done in preparation for Python 3.12 becoming the default python interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work of @daniruiz and other contributors. It addresses all the major repeating issues and outstanding PRs submitted, but never merged to-date.
Fixes include encoding and mixed indentation issues, Python 3 port, as well as Python 3.12 Syntax Warnings.