CV2-6604: Remove global keys permission#2379
Conversation
caiosba
left a comment
There was a problem hiding this comment.
Sawy, to be extra safe, I think we should make the team_id column on ApiKey mandatory. This should simplify the implementation since you won’t need to filter by non-null team IDs, and it also avoids the risk of forgetting to update that logic somewhere. Of course, you’ll need to run the rake task before deploying the code change; otherwise, the database migration will fail. Also, please rebase the PR since you already handled the last activity part in another PR.
@caiosba for now I added a validation inside the model ApiKey so I can deploy and run the rake task and after deploying this PR I'll make the team_id column mandatory |
Fixing tests (I have one test to fix) then run check-web tests |
|
@vasconsaurus would be good to get your eyes here too |
I'll take a look now during my morning. |
|
@melsawy, left a few questions just so I can better understand a few things. And one final question: are there any updates needed in the seeds script? |
|
|
@melsawy as we discussed, please keep the GraphQL field |
|
@caiosba please review latest changes while I am fixing a flaky test. |
Description
Check existing API keys and limit the usage of global keys.
References: CV2-6604
How to test?
For both cases I used graphql UI to run different quires
Checklist