Invoke sysops deployment with image tag for Live updates.#423
Closed
sonoransun wants to merge 54 commits intodevelopfrom
Closed
Invoke sysops deployment with image tag for Live updates.#423sonoransun wants to merge 54 commits intodevelopfrom
sonoransun wants to merge 54 commits intodevelopfrom
Conversation
- We are deprecating multiple parsers. They are either using the Zapier RSS/Check integration or the API.
- 20 minutes - RSS
- Estadao - RSS
- THIP - RSS
- PesaCheck - API
- Comprova - API
- Newtral - API (both newtral_fact_check and newtral_fakes)
- CekFakta - API (tempo_cekfakta parser)
- Tempo - API (tempo_cekfakta parser)
- Updating the README, so the how to deprecate is more visible.
References: 4383, 4349, 4347, 4300
PR: #384
It's now using RSS/Check Zapier integration to import fact checks. Note: We also had to update a test that was using the mafindo parser. Ticket: 4401 PR: #386
Vishvas News fact-checks are now being imported through Zapier.
Newschecker is now importing fact-checks through the zapier/check integration.
It is now importing fact-checks through the zapier/check integration. References: 4402
It is now importing fact-checks through the zapier/check integration. References: 4460
* It is now importing fact-checks through the zapier/check integration. References: 4494
Boom parsers are now importing fact-checks through the zapier/check integration. References: 4466
It is now importing fact-checks through the zapier/check integration. References: 4525 PR: #395
Uol and Comprova are now using the API, so we can deprecate their parser. References: 4403 PR: 396
Deprecates: CV2-5046 – We are now importing via the Zapier/Check integration: 1. Piyaoba CV2-4981 – We confirmed the parsers below can be deprecated: 1. aajtak_hindi – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881")) 2. africa_check – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881")) 3. agência lupa – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50850 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50850")) 4. alt_news_in – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881")) 5. fact_check_cite – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50850 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50850")) 6. globo – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881")) 7. la_silla_vacia – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=50881")) 8. vera_files – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=51344 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=51344")) 9. vera_files_filipino – can be deprecated ([link](https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=51344 "https://meedan.atlassian.net/browse/CV2-4981?focusedCommentId=51344")) References: 5046, 4981 PR: 401
1. climate_fact_check 2. gesis_claims 3. tfc_taiwan
Deprecate the Tsek.ph parser. We are now using another integration. References: CV2-6221
Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: v2`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
It was confirmed by program that these two parsers are no longer used. References: CV2-6236
Code Climate has been discontinued following its acquisition. We need to fully remove its integration from Fetch. This ticket aims to only do that. Note: I also removed DEPLOY_ENV=travis, since we no longer use Travis. References: CV2-6485, CV2-6593
Deprecate research parsers. References: CV2-6565
Deprecate parsers. References: CV2-6565 Sidenote: This test was failing: spec/lib/db_integration_test.rb. Now that we have only a couple partners, tests were running too fast and ClaimReview was returning nil, which was causing tests to fail. I did the easiest thing I could and added a sleep, with the least amount of time I could, which fixed this.
* It is now importing fact-checks through the zapier/check integration. References: 4494
ClaimReviewParser.parsers already returns only enabled parsers. So when we try `!ClaimReviewParser.parsers[service].deprecated` with a deprecated service, it returns nil. Which causes: "\"error_message\":\"undefined method `deprecated' for nil:NilClass\", \"error_class\":\"NoMethodError\",\"failed_at\":1761238248.0907707, \"retry_count\":6,\"retried_at\":1761239681.7711115}"}"
…nt (#417) We seem to be getting: `undefined method search' for nil:NilClass:00:00`. Reviewing both portuguese and spanish pages, it looks like the class `article-body__content` is now `article-body-module__content`. References: CV2-6609 I was able to reproduce the error by mismatching the classname: ``` 1) Reuters instance parses a raw_claim_review Failure/Error: header = page.search('div[class^="article-body-module__content"]').first.search('h2[data-testid="Heading"]').last NoMethodError: undefined method `search' for nil:NilClass # ./lib/claim_review_parsers/reuters.rb:44:in `claim_result_from_subhead' # ./lib/claim_review_parsers/reuters.rb:51:in `claim_result_from_page' # ./lib/claim_review_parsers/reuters.rb:59:in `parse_raw_claim_review' # ./spec/lib/claim_review_parsers/reuters_test.rb:20:in `block (3 levels) in <top (required)>' # /usr/local/bundle/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>' ```
Add information on how to verify services, claims and jobs state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for deployment workflow invocation with an image_tag input used for Live cluster updates. This resolves an error where git_sha based deployments lacked sufficient lifecycle policy in ECR to keep services running during ongoing development and CI/CD builds.
See also: https://meedan.atlassian.net/browse/CV2-6664
How has this been tested?
These changes were tested manually.
Checklist