Open
Conversation
The Janus API secret and the HTTPS options for the maintenance interface were not handled.
lminiero
reviewed
Oct 15, 2025
| basePath: rest.basePath, | ||
| app: rest.app | ||
| app: rest.app, | ||
| https: rest.https |
Member
There was a problem hiding this comment.
Not sure what this is supposed to do? But if you're adding properties to the constructor that were not there before, they should be validated first, especially if they're expected to be of a specific type. See what we do for existing properties in the lines above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Janus API secret and the HTTPS options for the maintenance interface were not handled.