remove unprofessional quote from README#86
Open
bbrewer-forge wants to merge 1 commit intomeh:masterfrom
Open
Conversation
|
I strongly agree with this change. |
|
@meh what do you think of this change? |
|
oh boy. |
|
If they don't update mainline may I suggest using my branch, https://github.com/noizu/amnesia I use this library on a multi million dollar IOT project so I will continue to maintain it. It removes the offending readme passage, adds support for compressed det tables and uses an alternative version of Exquisite which has a bug fix for the and, or clause handling of where statements in elixir 1.7 and above. Amnesia diff Exquisite Diff |
khionu
approved these changes
Jan 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to use this library on a open source project, but I'm pretty sure the quote I'm suggesting for removal would violate our code of conduct.