Open
Conversation
guidocella
force-pushed
the
swap-layout
branch
from
93be52f to
66dc7a3
Compare
Member
|
melonDS team, your thoughts on this? |
Member
|
Looks ok to me. EDIT: building it right now |
guidocella
force-pushed
the
swap-layout
branch
from
66dc7a3 to
e778ecc
Compare
Contributor
Author
|
I did not see the edit. It now goes Natural →Horizontal → Hybrid →Natural or Natural →Vertical → Hybrid → Natural. |
Closes melonDS-emu#1868. Supersedes melonDS-emu#1020.
guidocella
changed the title
guidocella
force-pushed
the
swap-layout
branch
from
e778ecc to
da68aa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually switches back to the natural layout when possible depending on the current rotation.
Closes #1868.
Supersedes #1020.