-
Notifications
You must be signed in to change notification settings - Fork 64
perf: fn rav1d_create_lf_mask_{intra,inter}: store as u16s
#1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kkysen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iximeow, @coderkalyan, if you want to review.
coderkalyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending the open comments, LGTM.
fn rav1d_create_lf_mask_intra: store as u16sfn rav1d_create_lf_mask_{intra,inter}: store as u16s
|
Will try to take a look at this tomorrow! |
Previously, two adjacent 8-bit stores were done. By doing them as `u16`s instead of `[u8]`s/`[u8; 2]`s, we can get a single 16-bit store to be emitted instead.
Same as for `fn rav1d_create_lf_mask_intra`.
10da56b to
f7fd7df
Compare
…can safely treat it as `u16`s
coderkalyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot about this - but with the AlignedVec2, LGTM!
Previously, two adjacent 8-bit stores were done. By doing them as
u16s instead of[u8]s/[u8; 2]s, we can get a single 16-bit store to be emitted instead.This gets
strhs emitted instead of the pair ofstrbs previously.Based on what @iximeow found in iximeow@e133a89 and #1401 (comment).
Before:
After: