Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/TestPWTCommands.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Script tests

on:
push:
branches:
branches:
- master
paths:
- 'pnpm-lock.yaml'
Expand All @@ -24,7 +24,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: [16, 18]
node: [18, 20]
os: [windows-latest, ubuntu-latest]
steps:
- name: "Checking-out code"
Expand All @@ -42,6 +42,11 @@ jobs:
if: matrix.node == 18
with:
version: 10
- name: Setup pnpm
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0
if: matrix.node == 20
with:
version: 10

- name: "Defining node version"
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
Expand Down
23 changes: 12 additions & 11 deletions packages/command-tests/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ const LIMIT_TESTS = !!process.env.LIMIT_TESTS;
const PARALLELISM = 4;

const CONFIGS = [
["web", "full", "ts", "8.0"],
["native", "full", "ts", "8.6"],
["web", "full", "ts", "8.6"],
["web", "full", "js", "8.7"],
["web", "full", "ts", "8.9"],
["native", "full", "ts", "8.9"],
// ["web", "full", "ts", "8.0"],
// ["native", "full", "ts", "8.6"],
// ["web", "full", "ts", "8.6"],
// ["web", "full", "js", "8.7"],
// ["web", "full", "ts", "8.9"],
// ["native", "full", "ts", "8.9"],
Comment on lines +17 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is forgotten.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Ali's point, shouldn't this be deleted?

["web", "full", "js", "latest"],
["web", "full", "ts", "latest"],
["native", "full", "js", "latest"],
Expand Down Expand Up @@ -376,14 +376,15 @@ async function execFailedAsync(command, workDir) {
function fixPackageJson(json) {
const devDependencies = {
"@types/jest": "^29.0.0",
"@types/react": "~18.2.0",
"@types/react-native": "~0.72.0",
"@types/react-dom": "~18.2.0",
"@types/react": "^19.0.0",
"@types/react-native": "0.78.2",
"@types/react-dom": "^19.0.0",
"@types/react-test-renderer": "~18.0.0"
};
const overrides = {
react: "18.2.0",
"react-native": "0.72.7"
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-native": "0.78.2"
};

Object.keys(devDependencies)
Expand Down
2 changes: 1 addition & 1 deletion packages/command-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"devDependencies": {
"@prettier/plugin-xml": "^2.2.0",
"@types/jest-image-snapshot": "^4.3.1",
"@types/node": "^16.11.19",
"@types/node": "^18.0.0",
"@types/node-fetch": "2.6.1",
"@types/shelljs": "^0.8.9",
"@types/xml2js": "^0.4.5",
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading