-
Notifications
You must be signed in to change notification settings - Fork 4
WIP: copilot hook POC #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Quick notes on what I tried re: copilot model detection:
To clarify what I mean be "upstream changes" being needed: the cleanest path here is probably just copilot-cli adding the model information to the payload passed to the hook. |
|
Thanks to @spencatro-pub for the PR, I’ll review it soon. Quick heads-up: I’m in the middle of a major update to Agentblame v3 to support improved diffing (via a snapshot-based approach), prompt capture, and attribution of lines back to prompts (and related metadata). This started as a small change but has grown significantly; I expect to wrap it up in the next couple of days. Once v3 lands, you’ll likely need to rebase and test against it, then submit an updated PR. |
|
Sure thing! I am excited to see what v3 brings. And yeah, I wouldn't worry too much about reviewing this yet (hence WIP). I imagine this feature will live in a branch for a while; again I do think agentblame will need changes in copilot upstream to fully claim support. (I was foolishly hoping copilot-cli might be open source so I could go sign a CLA, but appears not to be the case... darn. I'll try to get some better info to file a clear issue.) It looks like they are going for a near copy of claude's hooks, so hopefully the following design/impl there will be pretty straightforward on their end. But yes, agreed, this branch is not worth actual scrutiny yet (esp if no one else on the team is even using copilot-cli yet, I am happy to drive my own monster for a bit). I def need to bake on this branch, find the edge cases, and learn more about the potentially quite vast schism between MS's docs and current hook implementation 😅 |
|
Please update the PR for the latest agentblame version. |
muraalee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agent Blame 3.0 has been shipped, please pull from main and send me the PR
66d64cd to
c785bf3
Compare
|
Backed out the v2 implementation, going to study v3 and copilot a little. Will either update or close this PR this week, but for now this is just for reference in case anyone else out there also wants to hack on copilot. |
baa868d to
f21d6ab
Compare
|
Added MVP for v3 copilot-cli snapshot tracking. Open issues: Quick demo video: |
This change gets basic hooks working in copilot. There are still issues: * No model attribution * Only works in copilot-cli Anecdotally, this might be a little overly aggressive at calling lines AI when they might have been human. I am not sure if this is specific to copilot, or would also be an issue in other harnesses as well. This definitely needs more baking, but I think this is a decent starting point.
…opilot tool payloads a bit
a0d864e to
9f17fe2
Compare
This change gets basic hooks working in copilot cli. There are still issues:
Anecdotally, this might be a little overly aggressive at calling lines AI when they might have been human. I am not sure if this is specific to copilot, or would also be an issue in other harnesses as well.
This definitely needs more baking, but I think this is a decent starting point.