Skip to content

Conversation

@markovejnovic
Copy link
Collaborator

No description provided.

@markovejnovic
Copy link
Collaborator Author

/review

1 similar comment
@markovejnovic
Copy link
Collaborator Author

/review

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Feb 9, 2026

Mesa Description

This pull request introduces a generic inode cache (ICache) to unify inode and file handle management across the LocalFs and Mescloud filesystem implementations.

Previously, both filesystems had separate, duplicated logic for managing inode lifecycles, reference counting, and attribute caching. This refactoring centralizes that logic into a new, reusable icache module (src/fs/icache).

Key changes include:

  • New Generic ICache: A new src/fs/icache module was added, providing a generic cache for inode control blocks (ICBs) with built-in reference counting and file handle allocation.
  • LocalFs Refactor: The local filesystem's custom inode_table was replaced with the new generic ICache, simplifying its implementation.
  • Mescloud Refactor: A new MescloudICache was created as a specialized wrapper around the generic ICache. All mescloud filesystem components (MesaFS, OrgFs, RepoFs) were updated to delegate their inode management responsibilities to this new, centralized cache.

This change significantly reduces code duplication, improves consistency, and simplifies maintenance for all filesystem implementations.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 5953938...c1015dd

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

7 files reviewed | 0 comments | Edit Agent SettingsRead Docs

@markovejnovic markovejnovic force-pushed the marko/mes-699-commonize-dcache-implementations branch from b645cd9 to 735d293 Compare February 10, 2026 00:05
# This is the 1st commit message:

chore: Commonize icache

# The commit message #2 will be skipped:

# Migrate RepoFs to DCache
#
# Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# The commit message #3 will be skipped:

# Migrate OrgFs to DCache
#
# Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@markovejnovic markovejnovic force-pushed the marko/mes-699-commonize-dcache-implementations branch from 735d293 to af7bc42 Compare February 10, 2026 00:06
@markovejnovic markovejnovic merged commit 6fc3cda into main Feb 10, 2026
6 checks passed
@markovejnovic markovejnovic deleted the marko/mes-699-commonize-dcache-implementations branch February 10, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant