[1/2] Decouple Envs from version: Revive-scripts#392
Open
burtenshaw wants to merge 11 commits intomainfrom
Open
[1/2] Decouple Envs from version: Revive-scripts#392burtenshaw wants to merge 11 commits intomainfrom
burtenshaw wants to merge 11 commits intomainfrom
Conversation
Contributor
Greptile SummaryThis PR consolidates and enhances the Hugging Face deployment scripts. Three unused scripts (
Critical Issue Found:
Confidence Score: 1/5
Important Files Changed
Flowchartflowchart TD
A[Start Deployment] --> B{Deploy All or Single?}
B -->|All| C[Discover all deployable envs]
B -->|Single| D[Use specified env]
C --> E[For each environment]
D --> E
E --> F[Create staging directory]
F --> G[Pin OpenEnv refs to version]
G --> H[Strip dev artifacts]
H --> I[Create Dockerfile with base image]
I --> J[Generate README with HF metadata]
J --> K{Dry run?}
K -->|Yes| L[Print actions only]
K -->|No| M[Upload to HF Space]
M --> N[Add space to versioned collection]
N --> O{Skip collection?}
O -->|No| P[Update HF collection via manage_hf_collection.py]
O -->|Yes| Q[Skip collection update]
P --> R[Deployment complete]
Q --> R
L --> R
Last reviewed commit: 6a85f22 |
Contributor
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/deploy-hf-env.yml
Line: 133:138
Comment:
This workflow references `deploy_to_hf.sh` which was deleted in this PR. Update to use `prepare_hf_deployment.sh` instead.
```suggestion
chmod +x scripts/prepare_hf_deployment.sh
if [ -n "${{ github.event.inputs.base_image_sha }}" ]; then
./scripts/prepare_hf_deployment.sh --env "${{ matrix.environment }}" --base-sha "${{ github.event.inputs.base_image_sha }}"
else
./scripts/prepare_hf_deployment.sh --env "${{ matrix.environment }}"
fi
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/deploy-hf-env.yml
Line: 166:171
Comment:
This workflow references `deploy_to_hf.sh` which was deleted in this PR. Update to use `prepare_hf_deployment.sh` instead.
```suggestion
chmod +x scripts/prepare_hf_deployment.sh
if [ -n "${{ github.event.inputs.base_image_sha }}" ]; then
./scripts/prepare_hf_deployment.sh --env "${{ matrix.environment }}" --base-sha "${{ github.event.inputs.base_image_sha }}"
else
./scripts/prepare_hf_deployment.sh --env "${{ matrix.environment }}"
fi
```
How can I resolve this? If you propose a fix, please make it concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the scripts and deletes unused ones.
The main aim is to be able to delete all the envs to the hub as a collection like this which allows them to be tested.
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
Claude Code Review