Fix missing CommsScubaSample symbol in conda build #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The conda build was failing with `undefined symbol: _ZTIN5comms16CommsScubaSampleE` (typeinfo for `comms::CommsScubaSample`). Root cause: The `comms/utils/CMakeLists.txt` only collected `*.cc` files, but `CommsScubaSample.cpp` uses the `.cpp` extension, causing it to be excluded from the build. Fix: Updated the glob pattern to include both `*.cc` and `*.cpp` files, ensuring all source files in the logger directory are compiled. Reviewed By: dboyda, mlunar-meta Differential Revision: D91828594
|
@function47 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91828594. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The conda build was failing with
undefined symbol: _ZTIN5comms16CommsScubaSampleE(typeinfo forcomms::CommsScubaSample).Root cause: The
comms/utils/CMakeLists.txtonly collected*.ccfiles, butCommsScubaSample.cppuses the.cppextension, causing it to be excluded from the build.Fix: Updated the glob pattern to include both
*.ccand*.cppfiles, ensuring all source files in the logger directory are compiled.Reviewed By: dboyda, mlunar-meta
Differential Revision: D91828594