move getDeviceCq/getDeviceQp to ibgda #494
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@GirasoleY has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91729246. |
Summary:
Move CtranIbQpUtils.{h,cc} from comms/ctran/backends/ib to
comms/ctran/ibverbx as IbvQpUtils.{h,cc}. This refactor:
- Moves the QP utility functions to the ibverbx library where they belong
- Changes namespace from ctran::ib to ibverbx
- Renames types and functions to remove "CtranIb" prefix:
- CtranIbRemoteQpInfo → RemoteQpInfo
- ctranIbQpCreate → createRcQp
- ctranIbQpInit → initQp
- ctranIbQpRTR → rtrQp
- ctranIbQpRTS → rtsQp
This allows ibgda and other components to depend on ibverbx without
creating circular dependencies through backends/ib.
Reviewed By: minsii
Differential Revision: D91712642
Summary: Extract MLX5 hardware-specific structs from Ibvcore.h into a dedicated Mlx5core.h header. This separates low-level C structs that map directly to MLX5 NIC hardware structures (CQEs, WQEs, doorbells) from the higher-level ibverbs abstractions. These structs are used for: - GPU-direct RDMA (IBGDA) where kernels directly manipulate NIC structures - Host-side mlx5dv (direct verbs) operations - Parsing completion queue entries and work queue elements Reviewed By: minsii, cenzhaometa Differential Revision: D91715121
Summary: Decouple `getDeviceCq()`/`getDeviceQp()` from host CQ/QP structs. - Separates host IB abstractions from GPU device mapping logic - All GPU memory mapping stays in ibgda module - Eliminates architectural concern about GPU code in generic IB layer Changes: - Move IbvCq::getDeviceCq() -> ctran::ibgda::getDeviceCq() - Move IbvQp::getDeviceQp() -> ctran::ibgda::getDeviceQp() - Move sanityCheckCqInitialization helper to ibgda - Update call sites in init.cc to use new free functions - Move tests from IbverbxTest to InitTest Differential Revision: D91729246
GirasoleY
force-pushed
the
export-D91729246
branch
from
43b9426 to
6c4a586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Decouple
getDeviceCq()/getDeviceQp()from host CQ/QP structs.Changes:
Differential Revision: D91729246