fix: handle spawn ENOENT errors and prevent server crash#93
Open
Priyanshu-u07 wants to merge 3 commits intometacall:masterfrom
Open
fix: handle spawn ENOENT errors and prevent server crash#93Priyanshu-u07 wants to merge 3 commits intometacall:masterfrom
Priyanshu-u07 wants to merge 3 commits intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash in the FaaS server that happens when the
metacallbinary is missing from the system'sPATH. It handles theENOENTerror when starting child processes and prevents the server from crashing repeatedly during startup when trying to reload failed deployments.Related issue
Fixes #74
Type of change
How to test
metacallis missing.$env:PATH = "C:\Windows\system32;C:\Program Files\nodejs;C:\Windows\System32\WindowsPowerShell\v1.0\"; npm startPATH="/usr/bin:/bin" npm startmetacall-deploy --devspawn metacall ENOENT) but remains online.Checklist
Notes for reviewers
proc.on('error')listener indeploy.tsto handle spawn failures gracefully without crashing.autoDeploy.ts, the implementation now logs and skips failures instead of deleting the cached app folder. This prevents startup crash loops while keeping user data safe during temporary environment issues.Release notes
Fixed a fatal server crash and startup loop occurring when the MetaCall binary is missing from the environment PATH.