Added dependency fontawesome package#30
Open
raiyankamal wants to merge 1 commit intometeor-useraccounts:masterfrom
Open
Added dependency fontawesome package#30raiyankamal wants to merge 1 commit intometeor-useraccounts:masterfrom
raiyankamal wants to merge 1 commit intometeor-useraccounts:masterfrom
Conversation
Member
|
I'm aware there are some default values for the icons set to FontAwesome classes... At the same time, I'm not sure everyone would be fine by getting FontAwesome added by default. Does this makes any sense? |
Author
|
I understand that some people may not intend to use FA, I myself didn't. But I had to get it anyways to make the icons show up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the login form is used without installing the fontawesome package, the social media icons (FB, twitter etc.) don't show up. I was able to resolve this in my environment by adding the fontawesome package. I believe this package should be included as one of the dependencies.