Conversation
Collaborator
|
Most of the tests fail on |
Collaborator
Author
|
I will play around with this part. I saw it in the original PR, but I probably got too excited about this, so I will revert to the original code. |
radekmie
reviewed
Nov 28, 2023
radekmie
approved these changes
Nov 29, 2023
jankapunkt
approved these changes
Nov 29, 2023
Collaborator
Author
|
@radekmie @jankapunkt let's create a new 2.x release with these PRs and the async PRs that are already in master. |
Collaborator
|
@StorytellerCZ I agree but I also just got confirmation that #426 is working stable so we should get this in the next 2.x release so let's add this fix, too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking inspiration from #397, migrate
blazepackage in a smaller way to ES6.Also update dependencies.