feat(blaze): Add visual error indicator for development#481
Open
wreiske wants to merge 3 commits intometeor:masterfrom
Open
feat(blaze): Add visual error indicator for development#481wreiske wants to merge 3 commits intometeor:masterfrom
wreiske wants to merge 3 commits intometeor:masterfrom
Conversation
- Add error badge in bottom-left corner showing error count - Add modal with detailed error information and stack traces - Implement graceful failure with inline placeholders for missing templates - Add error deduplication to prevent duplicate entries - Integrate with HMR to auto-clear errors when templates are fixed - Add accessibility features (ARIA labels, keyboard navigation) - Auto-disable in production mode - Add TypeScript definitions for new public API BREAKING CHANGE: Missing template errors now show placeholders instead of throwing, which may change error handling behavior in some edge cases.
Member
|
loved, waitting for the green CI |
italojs
requested changes
Nov 25, 2025
| const error = new Error("No such template: " + name); | ||
| Blaze._reportException(error, 'Template lookup error:'); | ||
| // Return an error placeholder template instead of throwing | ||
| return Blaze._errorPlaceholder(name, error); |
Member
There was a problem hiding this comment.
To avoid a breaking change, we can add the errors in a public/exported/global array, maintaining the current error throw.
Then we can handle the frontend template with a try/catch; it will maintain the current error handling behavior without breaking anyone and will add this new error list as a new or optional feature.
Enhances Blaze template compilation error handling to display errors in the browser overlay and console, making them more visible to developers. Also fixes an instanceof check in html-scanner-tests.js and ensures parse errors are properly propagated in html-tools. Updates package versions and interdependencies to 2.0.1 for consistency.
Collaborator
|
What's the actual issue with the ci here? Is this a test runner issue or due to a breaking change? |
Collaborator
|
We can continue with this, once #486 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Missing template errors now show placeholders instead of throwing, which may change error handling behavior in some edge cases.
Before Change
Before this PR, blaze template issues would just result in the entire app not working.
After Change
Now the app works, AND it will gracefully continue rendering the rest of the app! Also a nice little error window to know where you messed up.