Changed from ionic-plugin-keyboard to cordova-plugin-keyboard#378
Open
ghost wants to merge 3 commits intometeoric:masterfrom
Open
Changed from ionic-plugin-keyboard to cordova-plugin-keyboard#378ghost wants to merge 3 commits intometeoric:masterfrom
ghost wants to merge 3 commits intometeoric:masterfrom
Conversation
Refactored ionKeyboard to suits changes.
ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an external keyboard the view would be shrunk to the software keyboard size not the size of the accessory bar. Using cordova-plugin-keyboard over ionic-plugin-keyboard fixes this change. We no longer need to alter the bottom property as cordova-plugin-keyboard's shrinkView preference (in config.xml) makes this change itself.