Masking changes to hail_size plugin #2228
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a scientific assurance review (EPPT-2792: Hail Size - Science Assurance) it was shown that the EPP workflow for hail size is not consistent with the parameter it is replacing (shown in GPP display). As a result, this suggests that something is going wrong within the EPP workflow, potentially due to a missing or misconfigured processing step.
To ensure consistency and reliability across platforms, it is recommended that the EPP workflow be reviewed in detail, with particular attention paid to the hail_size IMPROVER plugin.
The problem needs to be identified and the workflow adjusted so we can ensure that the science has been implemented correctly and thus we can scientifically assure that the diagnostics produced from EPP Workflows match the diagnostics we are replacing.
User Story
As a scientist I would like the hail size workflow design reviewed.
Currently the hail size output from the EPP workflow is not consistent with the GPP display.
I would like the hail size EPP workflow to be investigated, identifying where there may be gaps or errors in the workflow design that is causing the inconsistencies between the workflow and GPP display output.
After the issue has been identified the workflow should be updated so the output is consistent with the GPP display, this can then be scientifically assured.
Testing: