Avoid namespace ambiguity#2
Open
Felix-El wants to merge 1 commit intomeyerj:fix-1343-melodic-devel-3from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for sharing the patch. I'm trying it locally.
However, I've faced issues compiling one existing node with the patched roscpp: the node defines a
time_pointat global scope and later, whencondition_variable.his included through a chain of other include files, we have an ambiguity there.It sure is not good practice to have stuff at global scope but still, to avoid the issue for others, I'd propose to get rid of 'using namespace boost::chrono;' in favor of a namespace alias.
Guess I just learned that even scoped 'using namespace ...' is not great for use in header files, since the environment we're compiling in is controlled by the includer.
Best Regards
-Felix