Open
Conversation
Owner
|
Thank you kennethmitra for your pull request. Work is very busy for me at the moment. However, when I get a chance over the next few weeks I will review your pull request and if everything is in order I will gratefully merge your code. Thank you again, Martin |
EmperorTransisthor
suggested changes
Jan 17, 2022
| with open(file, 'a') as writer: | ||
| writer.write(exit_msg + "\n") | ||
|
|
||
| if log_type == "csv": |
There was a problem hiding this comment.
elif would be better instead of multiple if statements since we need to check which log_type was chosen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the option to generate a csv file instead of the text log file.
This removes the "-n" argument and replaces it with "-t" to specify the log file type (options: "text", "csv", or "none")