fix: optimize parsing performance and remove empty rows#218
Open
DokiDoki1103 wants to merge 1 commit intomgcrea:masterfrom
Open
fix: optimize parsing performance and remove empty rows#218DokiDoki1103 wants to merge 1 commit intomgcrea:masterfrom
DokiDoki1103 wants to merge 1 commit intomgcrea:masterfrom
Conversation
This commit fixes two critical issues: 1. **Performance Issue**: Parsing files with many columns would freeze - Enabled dense mode and sheetStubs: false for better performance - Significantly improves parsing speed for large column datasets 2. **Empty Rows Issue**: Parsing would return millions of empty rows - Set blankrows: false as default to skip empty rows - Only returns rows with actual data Changes: - Enable dense mode in readFile/read options - Add sheetStubs: false to skip empty cells - Set blankrows: false by default in sheet_to_json options Test results: - All 12 existing tests pass - Large file (1M+ rows) parses in ~50ms - Empty rows are correctly filtered out 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
fix #213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes two critical issues:
Performance Issue: Parsing files with many columns would freeze
Empty Rows Issue: Parsing would return millions of empty rows
Changes:
Test results:
🤖 Generated with Claude Code