Skip to content

fix: optimize parsing performance and remove empty rows#218

Open
DokiDoki1103 wants to merge 1 commit intomgcrea:masterfrom
DokiDoki1103:fix/performance-and-empty-rows
Open

fix: optimize parsing performance and remove empty rows#218
DokiDoki1103 wants to merge 1 commit intomgcrea:masterfrom
DokiDoki1103:fix/performance-and-empty-rows

Conversation

@DokiDoki1103
Copy link

This commit fixes two critical issues:

  1. Performance Issue: Parsing files with many columns would freeze

    • Enabled dense mode and sheetStubs: false for better performance
    • Significantly improves parsing speed for large column datasets
  2. Empty Rows Issue: Parsing would return millions of empty rows

    • Set blankrows: false as default to skip empty rows
    • Only returns rows with actual data

Changes:

  • Enable dense mode in readFile/read options
  • Add sheetStubs: false to skip empty cells
  • Set blankrows: false by default in sheet_to_json options

Test results:

  • All 12 existing tests pass
  • Large file (1M+ rows) parses in ~50ms
  • Empty rows are correctly filtered out

🤖 Generated with Claude Code

This commit fixes two critical issues:

1. **Performance Issue**: Parsing files with many columns would freeze
   - Enabled dense mode and sheetStubs: false for better performance
   - Significantly improves parsing speed for large column datasets

2. **Empty Rows Issue**: Parsing would return millions of empty rows
   - Set blankrows: false as default to skip empty rows
   - Only returns rows with actual data

Changes:
- Enable dense mode in readFile/read options
- Add sheetStubs: false to skip empty cells
- Set blankrows: false by default in sheet_to_json options

Test results:
- All 12 existing tests pass
- Large file (1M+ rows) parses in ~50ms
- Empty rows are correctly filtered out

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@DokiDoki1103
Copy link
Author

fix #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant