Skip to content

Conversation

@falkTX
Copy link
Contributor

@falkTX falkTX commented May 3, 2024

This adds support for Cardinal-specific file browser API, which is does not block the main event loop unlike osdialog.
Compatibility with original VCV Rack is maintained by the use of a compiler macro only present during Cardinal builds.

@mgunyho
Copy link
Owner

mgunyho commented May 7, 2024

Thanks, I appreciate the contribution. However, I would prefer to keep only vanilla Rack-related code in this repo - I don't have the capacity to test also with Carla or others. Is it too much work for you to maintain a fork with this patch?

@falkTX
Copy link
Contributor Author

falkTX commented May 7, 2024

Typically I prefer to avoid forks if possible, as that creates more work when there is a need to update the plugins.
Instead of a "git pull" on a submodule, there is a whole rebase-and-push-to-fork thing needed, and can only be done by cardinal maintainers too unlike vs when everything is upstream.

@mgunyho
Copy link
Owner

mgunyho commented May 7, 2024

Hmm I see your point about the fork workflow being a bit convoluted.

If you have the plugin as a submodule, could it be possible to have a patch in your repo that you would then apply? See here or here

@falkTX
Copy link
Contributor Author

falkTX commented May 7, 2024

that would change the source code and make it "unclean" for every git diff, also not doable with cardinal having release tarballs and it becoming a mess to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants