avoid script execution if remote is a full HTML page#16
Open
Cerdic wants to merge 1 commit intomichael-lynch:masterfrom
Open
avoid script execution if remote is a full HTML page#16Cerdic wants to merge 1 commit intomichael-lynch:masterfrom
Cerdic wants to merge 1 commit intomichael-lynch:masterfrom
Conversation
TODO : need improvement if script in body part of the page
Owner
|
Is this necessary? I haven't tested the plugin using a remote page that includes a script but I don't think it should matter, because the |
Author
|
The problem is that |
wilfreddekok
approved these changes
May 14, 2017
There was a problem hiding this comment.
I don't see a merge conflict?
oops, didn't read @Cerdic 's latest comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO : need improvement if script in body part of the page