Skip to content

Conversation

@michaeljoelphillips
Copy link
Owner

@michaeljoelphillips michaeljoelphillips commented May 21, 2017

This PR upgrades the application to PHP 7 and Symfony 3.2 as well as incorporating Unit Tests as reported by TravisCI and CodeCov.

Fixes #1 thanks to: Herzult/php-ssh#63.

@codecov
Copy link

codecov bot commented May 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@ae81df7). Click here to learn what that means.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   75.38%           
  Complexity        ?      164           
=========================================
  Files             ?       18           
  Lines             ?      516           
  Branches          ?        0           
=========================================
  Hits              ?      389           
  Misses            ?      127           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/AppBundle/Factory/LinodeApiFactory.php 85.71% <ø> (ø) 3 <0> (?)
src/AppBundle/Model/MigrateConfig.php 80% <ø> (ø) 17 <0> (?)
src/AppBundle/Service/LinodeIpService.php 0% <0%> (ø) 3 <1> (?)
src/AppBundle/Form/MigrateType.php 100% <100%> (ø) 2 <0> (?)
src/AppBundle/Service/LinodeAvailService.php 100% <100%> (ø) 4 <1> (?)
src/AppBundle/Service/LinodeHostService.php 43.75% <100%> (ø) 7 <1> (?)
src/AppBundle/Form/CloneType.php 100% <100%> (ø) 3 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae81df7...c7fd1d9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@ae81df7). Click here to learn what that means.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   75.38%           
  Complexity        ?      164           
=========================================
  Files             ?       18           
  Lines             ?      516           
  Branches          ?        0           
=========================================
  Hits              ?      389           
  Misses            ?      127           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/AppBundle/Factory/LinodeApiFactory.php 85.71% <ø> (ø) 3 <0> (?)
src/AppBundle/Model/MigrateConfig.php 80% <ø> (ø) 17 <0> (?)
src/AppBundle/Service/LinodeIpService.php 0% <0%> (ø) 3 <1> (?)
src/AppBundle/Form/MigrateType.php 100% <100%> (ø) 2 <0> (?)
src/AppBundle/Service/LinodeAvailService.php 100% <100%> (ø) 4 <1> (?)
src/AppBundle/Service/LinodeHostService.php 43.75% <100%> (ø) 7 <1> (?)
src/AppBundle/Form/CloneType.php 100% <100%> (ø) 3 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae81df7...c7fd1d9. Read the comment docs.

@michaeljoelphillips michaeljoelphillips merged commit b2529d1 into master May 21, 2017
@michaeljoelphillips michaeljoelphillips deleted the refactor branch May 21, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants