You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like the recent updates of unicode-width have introduced some compatibility issues to downstreams like us. Several tests in this crate would fail even with a minor version change (to 0.13.0). By indicating ^0.1.0 in our cargo file, we already assumed that we'd be totally fine with any possible updates as long as they follow the semver convention so that our crate remains consistent. Unfortunately, the major version for the latest one 0.2.0 is still unchanged, which means it is uncertain whether there would be similar changes being introduced in its future updates.
But something for bwrap is already certain: if any breaking changes are introduced, our crate's major version will move forward, that say, the next update will be either locking unicode-width's version to the original one, or bumping the major version to 2. I am still trying to figure out the actual benefits that we could gain from unicode-width's recent updates, and will take action after evaluating the tradeoff.
The current code has been working fine since their previous fix (unicode-rs/unicode-width#67). The changes in 0.2 fails more half of our tests, would require significant changes to the algorithm. Currently I just don't have time for any extra new feature implementing for this crate so, unless all tests being passed, the unicode-width might stay 0.1.x for a while
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.