add gold client methods that use GOLD project and analysis ids#102
Open
sujaypatil96 wants to merge 4 commits intomainfrom
Open
add gold client methods that use GOLD project and analysis ids#102sujaypatil96 wants to merge 4 commits intomainfrom
sujaypatil96 wants to merge 4 commits intomainfrom
Conversation
sujaypatil96
changed the title
sujaypatil96
force-pushed
the
spatil/filter-by-projectids
branch
2 times, most recently
from
5effda8 to
7b3c3a1
Compare
Member
|
I believe code like this has been added to nmdc-runtime, so this could be closed. @sujaypatil96 please confirm or correct me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to add two methods to the GOLD client library that fetches biosamples and study by project id.
This is a direct necessity for the GROW dataset, since we have only Gp and Ga ids to work with. Perhaps it would be a good idea to add
get_project_by_analysis_id(),get_biosample_by_analysis_id()andget_study_by_analysis_id()in the future too.