old data test and delete the old ones by score#5
old data test and delete the old ones by score#5Kikobeats merged 1 commit intomicrolinkhq:masterfrom
Conversation
|
Thanks for that! I'm reviewing it and will be merge soon 🙂 |
|
I want to know the opinion @xdmnl because I want to integrate his recent PR: tj/node-ratelimiter#44 In your comment, you are suggesting use |
|
It is a trade-off between keeping all the data and do 2 reads or keeping only the maximum of timestamps requested by the limiter and then doing only 1 read. In any case, this PR is necessary. It fixes a bug that does not exist in the original library: not expiring out of date timestamps. |
|
Thanks for the feedback guys, released at |
I add a test for my example and change the get function where every time accessing the sorted sets deleting the old data by score
Closes #3