Skip to content

Conversation

@tuan-nguyen-fenwick
Copy link
Contributor

Summary

  • Overload the InsertAccScheduleName function to accept a new parameter for Internal Description input.
  • Set the internal description for row definitions that are created using the Demo Data tool.
  • Ability to update internal description for existing row definitions.
image

Work Item(s)

Fixes: #4311
Fixes: AB #580996
Fixes: AB #575837

@github-actions github-actions bot added the From Fork Pull request is coming from a fork label Aug 1, 2025
@tuan-nguyen-fenwick
Copy link
Contributor Author

Prerequisite

Target branch will be changed to main after completing this PR: #4162

@tuan-nguyen-fenwick tuan-nguyen-fenwick marked this pull request as ready for review August 1, 2025 07:35
@tuan-nguyen-fenwick tuan-nguyen-fenwick requested a review from a team as a code owner August 1, 2025 07:35
@aholstrup1
Copy link
Contributor

aholstrup1 commented Aug 1, 2025

Prerequisite

Target branch will be changed to main after completing this PR: #4162

@tuan-nguyen-fenwick
Did you agree with someone in Microsoft to open up PRs to the Demo Data tool in BCApps? If you haven't made any agreements with people in Microsoft, I think you should continue to open these PRs in ALAppExtensions. The PR you're referencing is still open and it's still something we're discussing how/if we're going to do. IMO until that PR is merged, contributions should go through the AlAppExtensions repo.

@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Aug 5, 2025
@tuan-nguyen-fenwick
Copy link
Contributor Author

Prerequisite

Target branch will be changed to main after completing this PR: #4162

@tuan-nguyen-fenwick Did you agree with someone in Microsoft to open up PRs to the Demo Data tool in BCApps? If you haven't made any agreements with people in Microsoft, I think you should continue to open these PRs in ALAppExtensions. The PR you're referencing is still open and it's still something we're discussing how/if we're going to do. IMO until that PR is merged, contributions should go through the AlAppExtensions repo.

@aholstrup1 Thank you for the clarification, and apologies for the mix-up on my end. I saw a comment on one of my PRs in the ALAppExtensions repo and assumed it needed to go into BCApps, so I figured I’d get a head start here. Appreciate you pointing it out!

@AleksanderGladkov AleksanderGladkov added Integration GitHub request for Integration area and removed Finance GitHub request for Finance area labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

From Fork Pull request is coming from a fork Integration GitHub request for Integration area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants