Skip to content

[Cryptography Management] Fix instability test #5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darjoo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Cryptography Management] Fix instability test #5169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16b702c
Fix test
darjoo Oct 15, 2025
a7b967c
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
darjoo Dec 9, 2025
06c2e7b
Fix comments
darjoo Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 42 additions & 4 deletions src/System Application/Test/Cryptography Management/src/RSATest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,22 +222,35 @@ codeunit 132617 "RSA Test"
EncryptingOutStream: OutStream;
EncryptedInStream: InStream;
EncryptedOutStream: OutStream;
DecryptedInStream: InStream;
DecryptedOutStream: OutStream;
PlainText: Text;
DecryptedText: Text;
DecryptionFailed: Boolean;
begin
// [SCENARIO] Decrypt text encrypted with use of PKCS#1 padding, using OAEP padding.
// [SCENARIO] Due to random padding, decryption may occasionally not throw but returns garbage data.
Initialize();

// [GIVEN] With RSA pair of keys, plain text and encryption stream
EncryptingTempBlob.CreateOutStream(EncryptingOutStream);
SaveRandomTextToOutStream(EncryptingOutStream);
PlainText := SaveRandomTextToOutStream(EncryptingOutStream);
EncryptingTempBlob.CreateInStream(EncryptingInStream);
EncryptedTempBlob.CreateOutStream(EncryptedOutStream);
RSA.Encrypt(PrivateKeyXmlStringSecret, EncryptingInStream, false, EncryptedOutStream);
EncryptedTempBlob.CreateInStream(EncryptedInStream);

// [WHEN] Decrypt encrypted text stream using OAEP Padding
DecryptingTempBlob.CreateOutStream(DecryptedOutStream);
asserterror RSA.Decrypt(PrivateKeyXmlStringSecret, EncryptedInStream, true, DecryptedOutStream);
DecryptionFailed := not TryDecryptWithOaepPadding(RSA, PrivateKeyXmlStringSecret, EncryptedInStream, DecryptedOutStream);

// [THEN] Either decryption fails with an exception, or the decrypted text is garbage (not equal to plaintext)
if not DecryptionFailed then begin
DecryptingTempBlob.CreateInStream(DecryptedInStream);
DecryptedText := Base64Convert.FromBase64(Base64Convert.ToBase64(DecryptedInStream));
LibraryAssert.AreNotEqual(PlainText, DecryptedText, 'Decryption failed with garbage data.');
end else
LibraryAssert.IsTrue(DecryptionFailed, 'Decryption failed with wrong padding.');
end;

[Test]
Expand All @@ -251,22 +264,47 @@ codeunit 132617 "RSA Test"
EncryptingOutStream: OutStream;
EncryptedInStream: InStream;
EncryptedOutStream: OutStream;
DecryptedInStream: InStream;
DecryptedOutStream: OutStream;
PlainText: Text;
DecryptedText: Text;
DecryptionFailed: Boolean;
begin
// [SCENARIO] Decrypt text encrypted with use of OAEP padding, using PKCS#1 padding.
// [SCENARIO] Due to random padding, decryption may occasionally not throw but returns garbage data.
Initialize();

// [GIVEN] With RSA pair of keys, plain text, padding and encryption stream
EncryptingTempBlob.CreateOutStream(EncryptingOutStream);
SaveRandomTextToOutStream(EncryptingOutStream);
PlainText := SaveRandomTextToOutStream(EncryptingOutStream);
EncryptingTempBlob.CreateInStream(EncryptingInStream);
EncryptedTempBlob.CreateOutStream(EncryptedOutStream);
RSA.Encrypt(PrivateKeyXmlStringSecret, EncryptingInStream, true, EncryptedOutStream);
EncryptedTempBlob.CreateInStream(EncryptedInStream);

// [WHEN] Decrypt encrypted text stream using PKCS#1 padding.
DecryptingTempBlob.CreateOutStream(DecryptedOutStream);
asserterror RSA.Decrypt(PrivateKeyXmlStringSecret, EncryptedInStream, false, DecryptedOutStream);
DecryptionFailed := not TryDecrypt(RSA, PrivateKeyXmlStringSecret, EncryptedInStream, DecryptedOutStream);

// [THEN] Either decryption fails with an exception, or the decrypted text is garbage (not equal to plaintext)
if not DecryptionFailed then begin
DecryptingTempBlob.CreateInStream(DecryptedInStream);
DecryptedText := Base64Convert.FromBase64(Base64Convert.ToBase64(DecryptedInStream));
LibraryAssert.AreNotEqual(PlainText, DecryptedText, 'Decryption failed with garbage data.');
end else
LibraryAssert.IsTrue(DecryptionFailed, 'Decryption failed with wrong padding.');
end;

[TryFunction]
local procedure TryDecryptWithOaepPadding(RSA: Codeunit RSA; XmlString: SecretText; EncryptedInStream: InStream; DecryptedOutStream: OutStream)
begin
RSA.Decrypt(XmlString, EncryptedInStream, true, DecryptedOutStream);
end;

[TryFunction]
local procedure TryDecrypt(RSA: Codeunit RSA; XmlString: SecretText; EncryptedInStream: InStream; DecryptedOutStream: OutStream)
begin
RSA.Decrypt(XmlString, EncryptedInStream, false, DecryptedOutStream);
end;

local procedure SaveRandomTextToOutStream(OutStream: OutStream) PlainText: Text
Expand Down
Loading