[Quality Management] - "Item Filter"; Text[400] to be replaced with Blob. Length of text variables can be unlimited. #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated "Condition Filter" and "Item Attribute Filter" fields in the "Qlty. Inspection Gen. Rules" page to use dedicated text variables for better clarity and maintainability. - Implemented OnValidate triggers for both filters to ensure proper setting and modification of the record. - Refactored code in various wizards (Prod. Gen. Rule, Rec. Gen. Rule, Whse. Gen. Rule) to utilize new methods for setting and getting condition filters. - Updated tests to reflect changes in the way condition filters are set, ensuring all relevant tests are passing with the new implementation. - Improved overall code readability and maintainability by replacing direct field access with method calls for setting filters.
…ilter_Text_with_BLOB
…ilter_Text_with_BLOB
…lty. Prod. Gen. Rule Wizard
…vent duplicate entries
… with flexible alternatives
…ilter_Text_with_BLOB
attilatoury
reviewed
Jan 9, 2026
|
|
||
| // [WHEN] CleanUpWhereClause400 is called with input where clause | ||
| Output := QltyFilterHelpers.CleanUpWhereClause400(InputWhereClause400Tok); | ||
| Output := QltyFilterHelpers.CleanUpWhereClause(InputWhereClause400Tok); |
Contributor
There was a problem hiding this comment.
Should we just remove the test then? The new function used here will not reduce the text length to 400 characters or less.
attilatoury
approved these changes
Jan 9, 2026
| { | ||
| Caption = 'Condition Filter'; | ||
| Description = 'Specifies the criteria for defining when to use this template. For example, if you wanted to only use a template for a certain item then you would define that item here.'; | ||
| ToolTip = 'Specifies the criteria for defining when to use this template. For example, if you wanted to only use a template for a certain item then you would define that item here.'; |
Contributor
There was a problem hiding this comment.
Why do we remove the tooltips?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced Item Filter Text[400] with BLOB
Same changes done for Condition Filter and Attribute Filter
Work Item(s)
Fixes AB#610919